Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to the description files. #23

Merged
merged 12 commits into from
Jan 3, 2023

Conversation

oussamaLaribi
Copy link
Contributor

Add an image to the description of rule s72 [PHP].

Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oussamaLaribi
I don't understand why you want to add an JPG image to docker instances

What is the purpose ?

@dedece35 dedece35 added the 🚀 enhancement New feature or request label Dec 21, 2022
@oussamaLaribi
Copy link
Contributor Author

oussamaLaribi commented Dec 22, 2022

Hi @oussamaLaribi I don't understand why you want to add an JPG image to docker instances

What is the purpose ?

Hi @dedece35, the purpose is to add benchmark images to the rule description. I tried with just the image source, but it is not loaded into the Sonor Qube description rule when I start docker instances. So I decided to add it to the instance and it worked.

@dedece35
Copy link
Member

dedece35 commented Dec 22, 2022

Hi @oussamaLaribi,
I've juste tested locally your PR but it is'nt ok for me, sorry. Several problems :

  • tool build docker image and start it, I must
    • modify docker-compose.yml to change 0.1.0-SNAPHOT versions to 0.1.1-SNAPSHOT version
    • next, change source: common to source: ./common
  • after SonarQube started, the image is broken (check joined capture) where image URL is http://localhost:9000/opt/sonarqube/common/images/php/s72_percent_comparison.jpg : for me it can't work because this url path is not exposed on SonarQube
    • i found some other images on SonarQube server where images are stored on directory /opt/sonarqube/images

for now, I d'ont have a solution, sorry, but please make checks again

Capture d’écran 2022-12-22 à 21 58 37

@oussamaLaribi
Copy link
Contributor Author

Hi @oussamaLaribi, I've juste tested locally your PR but it is'nt ok for me, sorry. Several problems :

  • tool build docker image and start it, I must

    • modify docker-compose.yml to change 0.1.0-SNAPHOT versions to 0.1.1-SNAPSHOT version
    • next, change source: common to source: ./common
  • after SonarQube started, the image is broken (check joined capture) where image URL is http://localhost:9000/opt/sonarqube/common/images/php/s72_percent_comparison.jpg : for me it can't work because this url path is not exposed on SonarQube

    • i found some other images on SonarQube server where images are stored on directory /opt/sonarqube/images

for now, I d'ont have a solution, sorry, but please make checks again

Capture d’écran 2022-12-22 à 21 58 37

Hi @dedece35, Okay I'll check it. Thanks.

@oussamaLaribi
Copy link
Contributor Author

Hi, @dedece35. I used a different option. I used Flickr for storing pictures it's free. "Flickr is a media platform used for uploading, organizing, and sharing digital media such as photos and videos."

Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment in changelog file, in "unreleased" part

@oussamaLaribi
Copy link
Contributor Author

please add a comment in changelog file, in "unreleased" part

Hi @dedece35, Okay I'll do it. Thanks.

@dedece35 dedece35 merged commit 26ae1a4 into green-code-initiative:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants